-
Notifications
You must be signed in to change notification settings - Fork 206
Add Blazor partial class support in Visual Studio. #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -47,20 +47,6 @@ Copyright (c) .NET Foundation. All rights reserved. | |
<ProjectCapability Include="SupportsTypeScriptNuGet" /> | ||
</ItemGroup> | ||
|
||
<!-- | ||
For now we need to treat component files as if they have a single file generator. This will allow us | ||
to trigger a workspace update for the declaration files when they change. | ||
--> | ||
<ItemGroup> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shoot we need to make this dependent on > 3.0 projects. Otherwise if a user downloads latest VS it will not properly work with older projects. |
||
<Content Update="**\*.razor"> | ||
<Generator>MSBuild:RazorGenerateComponentDeclarationDesignTime</Generator> | ||
</Content> | ||
|
||
<Content Update="$(_RazorComponentInclude)"> | ||
<Generator>MSBuild:RazorGenerateComponentDeclarationDesignTime</Generator> | ||
</Content> | ||
</ItemGroup> | ||
|
||
<!-- | ||
WebSdk imports these capabilities for nesting in DotNetCoreWeb projects. | ||
Conditinally import these capabilities if the project isn't targeting the WebSdk. | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,13 +29,6 @@ public RazorProjectEngine Create(RazorConfiguration configuration, RazorProjectF | |
|
||
initializer.Initialize(b); | ||
configure?.Invoke(b); | ||
|
||
// See comments on MangleClassNames | ||
var componentDocumentClassifier = b.Features.OfType<ComponentDocumentClassifierPass>().FirstOrDefault(); | ||
if (componentDocumentClassifier != null) | ||
{ | ||
componentDocumentClassifier.MangleClassNames = true; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we also remove support for There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah but there are some places it is used like in |
||
} | ||
}); | ||
} | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to target this per-version? I guess not because it's not really a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pranavkm - @ajaybhargavb did we build a 3.1 versioning scheme into the SDK yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's simpler for now if we just make this change happen to both 3.0 and 3.1 projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't think so. 3.0 is still the latest.