Improve debugging tooltip support #11877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement textdocument/_vs_dataTipRange lsp message which allows the vs debugger to better handle showing tooltips for the returned ranges. This is my first PR into razor since joining the team, so I'm expecting/hoping for lots of feedback about these changes as I'm still getting really early into getting a feel for the codebase. The change is fairly simple, and just adds a new endpoint for _vs_dataTipRange, and forwards the request to the csharp lsp implementation, extending AbstractRazorDelegatingEndpoint to hook into the existing delegating infrastructure.
alexgav
reviewed
May 21, 2025
...Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Debugging/DataTipRangeHandlerEndpoint.cs
Show resolved
Hide resolved
alexgav
reviewed
May 21, 2025
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Protocol/DelegatedTypes.cs
Outdated
Show resolved
Hide resolved
Contributor
wasn't requesting changes, clicked on the wrong choice by accident. Code looks great to me. |
davidwengier
approved these changes
May 22, 2025
src/Razor/src/Microsoft.CodeAnalysis.Razor.Workspaces/Protocol/DelegatedTypes.cs
Outdated
Show resolved
Hide resolved
…tatiprange 2) Seal a couple classes I added
|
Awesome, thank you so much @ToddGrun and team for all that you do out there. 🙏 |
This was referenced May 24, 2025
ToddGrun
added a commit
to ToddGrun/razor
that referenced
this pull request
Nov 6, 2025
Fixes dotnet#11880 This is a port of the non-cohosting support for this message done in dotnet#11877 Needed a Roslyn package update to at least 5.3.0-2.25555.17 to include dotnet/roslyn#81033. Roslyn has inserted this change into VS main, and the latest VS Main install includes the Roslyn side of this change.
ToddGrun
added a commit
that referenced
this pull request
Nov 6, 2025
* Port dataTipRange support to cohosting Fixes #11880 This is a port of the non-cohosting support for this message done in #11877 Needed a Roslyn package update to at least 5.3.0-2.25555.17 to include dotnet/roslyn#81033. Roslyn has inserted this change into VS main, and the latest VS Main install includes the Roslyn side of this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement textdocument/_vs_dataTipRange lsp message which allows the vs debugger to better handle showing tooltips for the returned ranges.
This is my first PR into razor since joining the team, so I'm expecting/hoping for lots of feedback about these changes as I'm still just getting a feel for the codebase. This change is fairly simple, adding a new endpoint for _vs_dataTipRange, and forwarding the request to the csharp lsp implementation. AbstractRazorDelegatingEndpoint is extended to hook into the existing delegating infrastructure.
Fixes #6688, https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2459195