Skip to content

Followups to previous PR that need EA changes #11949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 18, 2025
Merged

Followups to previous PR that need EA changes #11949

merged 10 commits into from
Jun 18, 2025

Conversation

@davidwengier
Copy link
Member

@davidwengier davidwengier commented Jun 13, 2025

Razor side of dotnet/roslyn#78949

Two followups from previous PRs:

Won't build, of course, without the above PR merged and packages referenced

@davidwengier davidwengier requested a review from a team as a code owner June 13, 2025 02:23
@davidwengier davidwengier mentioned this pull request Jun 13, 2025
Merged
DustinCampbell
DustinCampbell approved these changes Jun 13, 2025
View reviewed changes
Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

davidwengier added a commit to dotnet/roslyn that referenced this pull request Jun 14, 2025
@davidwengier
Expose a couple of things to Razor (#78949)
f8eb8e5 
Allow Razor to not have to copy the complex edit command name, and
override formatting settings (in tests for now, but possibly more later)

Razor side: dotnet/razor#11949
@davidwengier davidwengier requested a review from a team as a code owner June 17, 2025 04:14
@davidwengier davidwengier requested review from ToddGrun and removed request for a team June 17, 2025 07:40
@davidwengier
Copy link
Member Author

davidwengier commented Jun 17, 2025

If you have an appetite for really long boring PRs, this has now had a Roslyn bump, and includes the DocumentUri changes, largely copied from @ToddGrun's work in #11901

Can't quite merge yet, because the Roslyn insertion this package comes from hasn't merged yet.

ToddGrun
ToddGrun approved these changes Jun 17, 2025
View reviewed changes
Copy link
Contributor

@ToddGrun ToddGrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ToddGrun ToddGrun mentioned this pull request Jun 17, 2025
Closed
@davidwengier
Copy link
Member Author

davidwengier commented Jun 18, 2025

Integration tests are green: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=11784495&view=results

Mergin'!

@davidwengier davidwengier merged commit 0d68401 into dotnet:main Jun 18, 2025
16 checks passed
@davidwengier davidwengier deleted the RazorEAFollowups branch June 18, 2025 21:09
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Jun 18, 2025
This was referenced Jun 24, 2025
Closed
Closed
Closed
Closed
@RikkiGibson RikkiGibson modified the milestones: Next, 18.0 P1 Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DustinCampbell DustinCampbell DustinCampbell approved these changes

@ToddGrun ToddGrun ToddGrun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

18.0 P1

Development

Successfully merging this pull request may close these issues.

4 participants

@davidwengier @DustinCampbell @ToddGrun @RikkiGibson