Compiler: Add Parent property to nested tag helper objects #11953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add AllowedChildTagDescriptor.Parent -> TagHelperDescriptor - Add BoundAttributeDescriptor.Parent -> TagHelperDescriptor - Add BoundAttributeParamterDescriptor.Parent -> BoundAttributeDescriptor - Add TagMatchingRuleDescriptor.Parent -> TagHelperDescriptor - Add RequiredAttributeDescriptor.Parent -> TagMatchingRuleDescriptor
- Add nullability annotations - Use ArgHelper throughout
This can be retrieved via the Parent property.
This can be retrieved via the Parent property
DustinCampbell
changed the title
chsienki
approved these changes
Jun 16, 2025
davidwengier
approved these changes
Jun 16, 2025
Member
davidwengier
left a comment
davidwengier
left a comment
There was a problem hiding this comment.
Tooling looks good.
Do you remember if we still need a dual insertion for serialization format changes, for VS Code?
Member
Author
I don't recall. I was wondering about that too. I don't think we do because we deploy both RZLS and MS.VisualStudioCore.RazorExtension to VS Code at the same time and no longer have an EA from Razor to Roslyn. However, I wasn't deeply involved in that big EA change. |
Member
|
Thats what I think too, but I think is the first test of the theory. Will be easy enough to find out :) |
333fred
approved these changes
Jun 16, 2025
This was referenced Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This affects the Razor SDK. When the compiler flows to the .NET SDK, this commit will be needed: dotnet/sdk@a9d343d.
Add Parent properties to all of the nested tag helper objects:
AllowedChildTagDescriptor.Parent->TagHelperDescriptorBoundAttributeDescriptor.Parent->TagHelperDescriptorBoundAttributeParameterDescriptor.Parent->BoundAttributeDescriptorTagMatchingRuleDescriptor.Parent->TagHelperDescriptorRequiredAttributeDescriptor.Parent->TagMatchingRuleDescriptorThis removes the need for
BoundAttributeandBoundAttributeParameterDescriptorto duplicate theKindproperty fromTagHelperDescriptor.