Reduce allocations in WhereAsArray IA/IA.Builder extension methods #12051
+163
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very heavily inspired by Roslyn's implementation (https://github.com/dotnet/roslyn/blob/fadd60c39d63743cdaeacd2c3f8aa003f5bb7f58/src/Dependencies/Collections/Extensions/ImmutableArrayExtensions.cs#L546-L613) I needed the IA.Builder version of this for local changes, but separated this out into a separate PR.
davidwengier
approved these changes
Jul 23, 2025
| if (all) | ||
| { | ||
| all = false; | ||
| for (var j = 0; j < i; j++) |
Member
There was a problem hiding this comment.
Is there any benefit to setting the builder capacity here, to avoid resizing in this loop?
Contributor
Author
There was a problem hiding this comment.
Probably not. We are mid loop here so don't really know what an appropriate size would be. Additionally, this pooledbuilder is likely already large enough, so it doesn't seem worth the effort to try and make this any smarter in that regard.
This was referenced Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very heavily inspired by Roslyn's implementation
I needed the IA.Builder version of this for local changes, but separated this out into a separate PR.