Skip to content

Compiler: Reduce allocations in tag helper matching #12134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 22, 2025
Merged

Compiler: Reduce allocations in tag helper matching #12134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8ea4877
Change TagHelperIntermediateNode.TagHelpers property to ImmutableArray
DustinCampbell Aug 21, 2025
08e4731
Only store one tag helper object in an intermediate node
DustinCampbell Aug 21, 2025
c30dedd
Consolidate out parameters into struct result
DustinCampbell Aug 21, 2025
3513107
Add TagHelperMatchingConventions.GetAttributeMatches helper
DustinCampbell Aug 21, 2025
8232fb8
Fix #if..#endif definitions in SpanExtensions
DustinCampbell Aug 21, 2025
80b6e0d
Introduce DirectiveAttributeName helper struct
DustinCampbell Aug 21, 2025
4399da3
Clean up TagHelperDirectiveAttributeParameterIntermediateNode
DustinCampbell Aug 21, 2025
b4c358d
Clean up TagHelperDirectiveAttributeIntermediateNode
DustinCampbell Aug 21, 2025
e4ff368
Clean up TagHelperPropertyIntermediateNode
DustinCampbell Aug 21, 2025
5547cc9
Clean up TagHelperHtmlAttributeIntermediateNode
DustinCampbell Aug 21, 2025
3edf46f
Clean up TagHelperIntermediateNode
DustinCampbell Aug 21, 2025
f4e3531
CR Feedback: Set variable inside loop for consistency
DustinCampbell Aug 21, 2025
4968ee9
CR Feedback: Avoid extra ReadOnlySpan<char>.ToString() allocations
DustinCampbell Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 27 additions & 5 deletions ...iler/Microsoft.AspNetCore.Mvc.Razor.Extensions.Version2_X/test/InstrumentationPassTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,17 @@ public void InstrumentationPass_SkipsCSharpExpression_InsideTagHelperAttribute()

var builder = IntermediateNodeBuilder.Create(documentNode);

builder.Push(new TagHelperIntermediateNode());
builder.Push(new TagHelperIntermediateNode()
{
TagMode = 0,
TagName = "Test"
});

builder.Push(new TagHelperHtmlAttributeIntermediateNode());
builder.Push(new TagHelperHtmlAttributeIntermediateNode()
{
AttributeName = "Test",
AttributeStructure = 0
});

builder.Push(new CSharpExpressionIntermediateNode()
{
Expand Down Expand Up @@ -188,9 +196,17 @@ public void InstrumentationPass_SkipsCSharpExpression_InsideTagHelperProperty()

var builder = IntermediateNodeBuilder.Create(documentNode);

builder.Push(new TagHelperIntermediateNode());
builder.Push(new TagHelperIntermediateNode()
{
TagMode = 0,
TagName = "Test"
});

builder.Push(new TagHelperPropertyIntermediateNode());
builder.Push(new TagHelperPropertyIntermediateNode(match: default)
{
AttributeName = "Test",
AttributeStructure = 0
});

builder.Push(new CSharpExpressionIntermediateNode()
{
Expand Down Expand Up @@ -231,6 +247,8 @@ public void InstrumentationPass_InstrumentsTagHelper()

builder.Add(new TagHelperIntermediateNode()
{
TagMode = 0,
TagName = "Test",
Source = CreateSource(3)
});

Expand All @@ -254,7 +272,11 @@ public void InstrumentationPass_SkipsTagHelper_WithoutLocation()

var builder = IntermediateNodeBuilder.Create(documentNode);

builder.Push(new TagHelperIntermediateNode());
builder.Push(new TagHelperIntermediateNode()
{
TagMode = 0,
TagName = "Test"
});

// Act
ProjectEngine.ExecutePass<InstrumentationPass>(codeDocument, documentNode);
Expand Down
Loading