Fix invalid cast with end script tag containing code #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajaybhargavb
commented
Feb 7, 2019
| [Fact] | ||
| public void Tags_DesignTime() | ||
| { | ||
| DesignTimeTest(); |
There was a problem hiding this comment.
Added a code gen test because the failure was at the IR level.
NTaylorMullen
approved these changes
Feb 7, 2019
src/Razor/src/Microsoft.AspNetCore.Razor.Language/Legacy/HtmlMarkupParser.cs
Show resolved
Hide resolved
...ore.Razor.Language.Test/TestFiles/IntegrationTests/CodeGenerationIntegrationTest/Tags.cshtml
Outdated
Show resolved
Hide resolved
ajaybhargavb
force-pushed
the
ajbaaska/fix-script-tag
branch
from
97a1157 to
3175711
Compare
NTaylorMullen
added a commit
that referenced
this pull request
Sep 10, 2019
- One of the caveats with this approach is that you end up getting errors on components which are trying to bind event handlers. i.e. `<Counter onclick="@IncrementCount" />`. You get an error stating that you cannot convert a method delegate to object. This is because in non-component scenarios that line is understood as `__o = IncrementCount` where `IncrementCount` is a void returning method. - Made the experimental language version round trippable once serialized. - Added the Blazor ProjectEngine to the list of supported VSCode Razor project types. - Noticed that our testapp projects were incorrectly inheriting our test package references (Xunit and the like). #193
JunTaoLuo
pushed a commit
to dotnet/aspnetcore
that referenced
this pull request
May 17, 2020
\n\nCommit migrated from dotnet/razor@56fa17b
dougbu
pushed a commit
to dougbu/razor-compiler
that referenced
this pull request
Nov 17, 2021
\n\nCommit migrated from dotnet/razor@56fa17b Commit migrated from dotnet/aspnetcore@daeb4f80d1f0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/784393