Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added RazorSyntaxGenerator to the repo #313

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

ajaybhargavb
Copy link
Contributor

This is basically a copy-modify from https://github.com/dotnet/roslyn/tree/master/src/Tools/Source/CompilerGeneratorTools/Source/CSharpSyntaxGenerator

  • Added the tool that we use to automatically generate syntax nodes/factories
  • Added a Readme
  • Intentionally not adding it to the sln since we don't need it to be there

@ajaybhargavb ajaybhargavb force-pushed the ajbaaska/syntax-generator branch from 50ae687 to aa4c913 Compare March 8, 2019 01:17
@rynowak
Copy link
Member

rynowak commented Mar 8, 2019

@Eilon needs to approve this, not me 😆

@ajaybhargavb
Copy link
Contributor Author

@Eilon needs to approve this, not me

@Eilon, I believe you approved it over email along with all the other syntax node infrastructure. But I'll wait for you to review this once again just in case things have changed.

@ajaybhargavb ajaybhargavb requested a review from Eilon March 8, 2019 02:36
@Eilon
Copy link
Member

Eilon commented Mar 8, 2019

Oh yeah this. If it's the same general stuff as from a while ago, this is approved.

@ajaybhargavb ajaybhargavb merged commit cdafa55 into master Mar 8, 2019
@ajaybhargavb ajaybhargavb deleted the ajbaaska/syntax-generator branch March 8, 2019 18:40
JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request May 27, 2020
dougbu pushed a commit to dougbu/razor-compiler that referenced this pull request Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants