Wrap with tag integration tests #8116

davidwengier · 2023-01-11T09:58:56Z

At time of writing, one test is failing, just waiting on new images to be published for integration test runs.

src/Razor/test/Microsoft.VisualStudio.Razor.IntegrationTests/WrapWithTagTests.cs

ryanbrandenburg · 2023-01-17T23:45:53Z

Under the covers you've run into the following error in the Rename tests which is polluting your other tests:

System.NullReferenceException: Object reference not set to an instance of an object.
 at Microsoft.VisualStudio.Text.Operations.SelectionState.EditToDataMap(ITextView view)
 at Microsoft.VisualStudio.Text.Operations.SelectionState..ctor(ITextView view)
 at Microsoft.VisualStudio.Text.Operations.Implementation.BeforeTextBufferChangeUndoPrimitive.Create(ITextView textView, ITextUndoHistory undoHistory)
 at Microsoft.VisualStudio.Text.Operations.Implementation.EditorOperations.AddBeforeTextBufferChangePrimitive()
 at Microsoft.VisualStudio.LanguageServer.Client.SnippetUtilities.ApplyDefaultTabStopSnippetTextEdit(JoinableTaskContext joinableTaskContext, TextEdit snippetTextEdit, SnapshotPoint triggerLocation, ITextBuffer textBuffer, ITextView textView, ITextUndoHistoryRegistry undoHistoryRegistryService, IAsyncCompletionBroker completionBroker, IOvertypeManagerFactory overtypeManagerFactory, IEditorOperationsFactoryService editorOperationsFactoryService)
 at Microsoft.VisualStudio.LanguageServer.Client.FormatOnTypeCommandHandler.<HandleOnAutoInsertAsync>d__16.MoveNext() 
--- End of stack trace from previous location where exception was thrown ---
 at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
 at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
 at Microsoft.VisualStudio.LanguageServer.Client.FormatOnTypeCommandHandler.
<ExecuteCommandHelperAsync>d__18.MoveNext() 
--- End of stack trace from previous location where exception was thrown ---
 at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
 at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
 at Microsoft.VisualStudio.Shell.VsTaskLibraryHelper.<>c__DisplayClass35_0.<<FileAndForget>b__0>d.MoveNext()

I would say to first pull latest and see if anything in my Quelling PR improves things. Then if you're still running into this reliably it's a useful case for investigating https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1715306/ and reason for them to prioritize it.

davidwengier · 2023-01-17T23:49:40Z

Maybe I'm missing something, but when I look I see one test failing this PR, which is the "SelfClosingTag" test, and I would expect that to fail as it was a bug in web tools and the fix hasn't shipped anywhere yet. You'll have to show me how to find the "under the covers" errors, but also possibly let me know why I should care??

ryanbrandenburg · 2023-01-18T00:46:37Z

Talked offline. The Rename thing is not necessarily the direct cause of the failures, but certainly doesn't make diagnosis easier.

davidwengier · 2023-01-18T19:52:56Z

/azp run

azure-pipelines · 2023-01-18T19:53:12Z