Add reference to ExternalAccess.RazorCompiler
#8142
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jjonescz
commented
Jan 17, 2023
•
jjonescz
commented
- Based on Consolidate roslyn versions #8103.
- Adding reference to the EA package into Razor source generator (without actually using it, that's in Emit host outputs #8242).
- The only relevant commit is d2b3dfa.
We had multiple sets of roslyn references, differing between the compiler and the tooling. This consolidates those versions and updates the compiler references to be inline with the tooling.
…nd EmbeddedAttribute.
jjonescz
force-pushed
the
ea-razor-compiler
branch
5 times, most recently
from
4063040 to
69cfb34
Compare
|
@jjonescz be sure to run this against https://devdiv.visualstudio.com/DevDiv/_build?definitionId=15591&_a=summary as well since we need to make sure that the changes work in both VSPreview and VSMain. In order for that pipeline to work for PR builds you need to manually push your branch to both the base GitHub repo (not your fork) and to razor's repo in dnceng (I know, it's super annoying). Feel free to message me if you run into trouble. |
ryanbrandenburg
approved these changes
Jan 19, 2023
...r/src/Microsoft.CodeAnalysis.Razor.Workspaces/ProjectSystem/DefaultProjectSnapshotManager.cs
Outdated
Show resolved
Hide resolved
...Studio.LanguageServices.Razor.Test/Microsoft.VisualStudio.LanguageServices.Razor.Test.csproj
Outdated
Show resolved
Hide resolved
jjonescz
force-pushed
the
ea-razor-compiler
branch
2 times, most recently
from
29e93ac to
c9d22d8
Compare
jjonescz
force-pushed
the
ea-razor-compiler
branch
from
c42ac51 to
425d1ed
Compare
jjonescz
force-pushed
the
ea-razor-compiler
branch
from
425d1ed to
d2b3dfa
Compare
|
Included in #8242. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.