fix-text-differ #8215
Merged
fix-text-differ #8215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LunicLynx
commented
Feb 3, 2023
| @@ -118,7 +118,7 @@ private static void ReturnArray(int[] array, bool clearArray = false) | |||
| // Does this index fall within page? If not, acquire the appropriate page. | |||
| if (index < page.Start || index >= page.Start + page.Length) | |||
| { | |||
| page = _pages[index % PageSize]; | |||
| page = _pages[index / PageSize]; | |||
There was a problem hiding this comment.
This logic only makes sense with division. Also this error does not happen with small files because of the if.
|
Too early for me to think about math. Paging @DustinCampbell Is this issue in P1? We need to service it if so. Also, perhaps a test? Even if it just created a really big file, formats it, and at least we'll know there aren't any exceptions thrown? |
|
Big "oops" for me! Although, I would've expected to see this show up in the benchmarks, which test a ~315KB file. |
DustinCampbell
approved these changes
Feb 4, 2023
DustinCampbell
added a commit
to DustinCampbell/razor
that referenced
this pull request
Feb 4, 2023
DustinCampbell
added a commit
to DustinCampbell/razor
that referenced
this pull request
Feb 4, 2023
DustinCampbell
added a commit
to DustinCampbell/razor
that referenced
this pull request
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encountered an IndexOutOfRange Exception here, when formatting a large .razor file.
The debugger showed that the pages array had 3 entries, the expression
index % PageSizeevaluated to some high values like 23300 % 20480.I think this should be an integer division instead of a modulo operation.