Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing global:: prefix to type inference method parameters #8247

Merged
merged 5 commits into from
May 1, 2023

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Feb 9, 2023

Fixes #7103.
Fixes #8316.

@jjonescz jjonescz marked this pull request as ready for review February 9, 2023 09:33
@jjonescz jjonescz requested a review from a team as a code owner February 9, 2023 09:33
@jjonescz jjonescz added the area-compiler Umbrella for all compiler issues label Feb 9, 2023
@jaredpar
Copy link
Member

The original bug had the synthetic type name being generated being a user defined type name. Whenever I see that my brain says

Are we making sure that we don't re-introduce the global::dynamic and global::(int x, int y) bugs again?

All the tests here though are around a generated IEnumerable<T>. Is there a way for the user to control the type name generated here such that it's a user defined type? The samples in the bug seem to indicate such is possible.

@jjonescz
Copy link
Member Author

All the tests here though are around a generated IEnumerable<T>

Those are only the existing tests. There's one new test with user-defined type global::MyApp.MyClass<T>.

Are we making sure that we don't re-introduce the global::dynamic and global::(int x, int y) bugs again?

Good question. Added a test demonstrating that tuples still work. (Dynamic probably cannot be verified here as this code path is only for generic types.)

@jjonescz jjonescz force-pushed the 7103-cascading-global branch from 8ab65b1 to 51f6b0d Compare February 13, 2023 11:22
@jjonescz
Copy link
Member Author

@chsienki @dotnet/razor-compiler for the second review

@jjonescz
Copy link
Member Author

@chsienki @dotnet/razor-compiler for a second review, please

@jjonescz jjonescz enabled auto-merge (squash) May 1, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-compiler Umbrella for all compiler issues
Projects
None yet
4 participants