Semantic tokens tests: Use Linq instead #8256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,7 +121,7 @@ public async Task VerifyGetClassificationsAsync(IEnumerable<ClassificationSpan> | |||
| } | |||
| } | |||
|
|
|||
| Assert.Equal(expectedArray.Length, actualArray.Length - actualOffset); | |||
| Assert.Equal(expectedArray.Length, actualArray.Length); | |||
There was a problem hiding this comment.
This assert is not doing anything any more: If the lengths weren't equal, we would have got index out of range exceptions on line 104/5.
I think this should be moved in front of the loop, just for good measure, and to provide a little more information than an index out of range exception would, should it ever fail.
| var actualSemanticClassifications = actualClassifications.Where(a => | ||
| a.ClassificationType.BaseTypes.Any() && | ||
| a.ClassificationType is ILayeredClassificationType layeredClassificationType && | ||
| layeredClassificationType.Layer == ClassificationLayer.Syntactic); |
There was a problem hiding this comment.
Shouldn't this now change to !=?
|
Definitely much easier to understand that moving two indexes. Which I didn't 😝 |
davidwengier
approved these changes
Feb 17, 2023
...st/Microsoft.VisualStudio.Razor.IntegrationTests/InProcess/EditorInProcess_Classification.cs
Show resolved
Hide resolved
|
Oh no, I take it back. If expected is longer than actual it will help. My bad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes