Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update binding redirects for Microsoft.Extensions.* dependencies #8422

Merged
merged 7 commits into from
Mar 15, 2023

Conversation

maryamariyan
Copy link
Member

@maryamariyan maryamariyan commented Mar 13, 2023

Summary of the changes

Update binding redirects for Microsoft.Extensions.* dependencies (Primitives etc.)

@maryamariyan maryamariyan requested a review from a team as a code owner March 13, 2023 20:51
@maryamariyan maryamariyan self-assigned this Mar 13, 2023
@maryamariyan maryamariyan changed the title Update VSIX binding redirects for Microsoft.Extensions.* dependencies Update binding redirects for Microsoft.Extensions.* dependencies Mar 13, 2023
@maryamariyan maryamariyan requested a review from a team as a code owner March 13, 2023 21:14
Copy link
Member

@DustinCampbell DustinCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I had a question about the binding redirects.

@maryamariyan
Copy link
Member Author

I'm hitting this runtime exception while testing the changes.

image

I'll look over at the commit history to see if there's more I need to change to get this loaded

@DustinCampbell
Copy link
Member

I'm hitting this runtime exception while testing the changes.

If this is within Visual Studio, it might be that we need to deploy a new dependency in the VSIX. Use fuslogvw to see if load failure is due to a dependency. The list here controls the list of external dependencies that are included in the VSIX.

@maryamariyan
Copy link
Member Author

maryamariyan commented Mar 14, 2023

If this is within Visual Studio, it might be that we need to deploy a new dependency in the VSIX. Use fuslogvw to see if load failure is due to a dependency. The list here controls the list of external dependencies that are included in the VSIX.

the load is trying to happen under path "C:\Program Files\Microsoft Visual Studio\2022\Preview\Common7\IDE" and that only has 5.0 and 6.0 versions of that assembly. 


UPDATE:
my hive folder was messed up and my local environment was out of date. By following the steps in the next comment, I got past this issue and was able to properly reset my environment and test the changes end-to-end

@maryamariyan
Copy link
Member Author

maryamariyan commented Mar 15, 2023

The CI is green.

Also in order to test manually the changes here, I followed the steps below thanks to @DustinCampbell 's guide on how to check if the binding redirects work properly as expected:

  • Close all running VS instances
  • Browse to %LocalAppData%\Microsoft\VisualStudio and delete the 17.0_xxxxxxxxRoslynDev folder. Note that xxxxxxxx will be filled in with a random ID.
  • Build Razor.sln within VS (build.cmd -deploy and then CTRL+F5 should suffice).
  • Confirm that a new 17.0_xxxxxxxxRoslynDev folder gets created.
  • Review the devenv.exe.config in that folder, to see if the correct binding redirect is happening to 7.0.0.
  • Launch VS instance with an without changes in this PR to confirm razor files get properly loaded for a sample blazor sever app

@maryamariyan
Copy link
Member Author

Added a PR improving our troubleshooting guide in the docs based on the steps mentioned in this PR:
#8431

@maryamariyan maryamariyan merged commit bf5d35e into main Mar 15, 2023
@maryamariyan maryamariyan deleted the binding-redirect branch March 15, 2023 21:44
allisonchou added a commit that referenced this pull request Mar 21, 2023
This reverts commit bf5d35e, reversing
changes made to c12b6f3.
allisonchou added a commit that referenced this pull request Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants