-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update binding redirects for Microsoft.Extensions.* dependencies #8422
Conversation
…(Primitives etc.)
11771f2
to
5bafb53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I had a question about the binding redirects.
src/Razor/src/Microsoft.VisualStudio.LanguageServerClient.Razor/RazorLanguageServerClient.cs
Outdated
Show resolved
Hide resolved
src/Razor/src/Microsoft.VisualStudio.RazorExtension/AssemblyBindingRedirects.cs
Outdated
Show resolved
Hide resolved
…r/RazorLanguageServerClient.cs Co-authored-by: Dustin Campbell <dustin@teamcampbell.org>
If this is within Visual Studio, it might be that we need to deploy a new dependency in the VSIX. Use fuslogvw to see if load failure is due to a dependency. The list here controls the list of external dependencies that are included in the VSIX. |
the load is trying to happen under path "C:\Program Files\Microsoft Visual Studio\2022\Preview\Common7\IDE" and that only has 5.0 and 6.0 versions of that assembly. UPDATE: |
The CI is green. Also in order to test manually the changes here, I followed the steps below thanks to @DustinCampbell 's guide on how to check if the binding redirects work properly as expected:
|
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/LoggerAdapter.cs
Outdated
Show resolved
Hide resolved
Added a PR improving our troubleshooting guide in the docs based on the steps mentioned in this PR: |
Summary of the changes
Update binding redirects for Microsoft.Extensions.* dependencies (Primitives etc.)