Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge duplicate tag helper descriptors #8730

Closed
wants to merge 3 commits into from

Conversation

jjonescz
Copy link
Member

Alternative to #8721.
Fixes #8718.

@jjonescz jjonescz added the area-compiler Umbrella for all compiler issues label May 18, 2023
@jjonescz jjonescz added this to the 17.7 P2 milestone May 18, 2023
@@ -115,7 +114,6 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
if (root is CompilationUnitSyntax { Members: [NamespaceDeclarationSyntax { Members: [ClassDeclarationSyntax classSyntax, ..] }, ..] })
{
var declaredClass = compilationWithDeclarations.GetSemanticModel(generatedDeclarationSyntaxTree).GetDeclaredSymbol(classSyntax, ct);
Debug.Assert(declaredClass is null || declaredClass is { AllInterfaces: [{ Name: "IComponent" }, ..] });
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken assert - a component does not have to inherit from IComponent, nothing stops users from declaring component like

@inherits object

This manifested in the new test ComponentAndTagHelper where a component inherits from TagHelper.

Scheme = "http"
};
requestFeature.Headers.Host = "localhost";
httpContext.Features.Set<IHttpRequestFeature>(requestFeature);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small improvement of the test infra to allow rendering also Blazor components.

@jjonescz jjonescz removed this from the 17.7 P2 milestone Jun 30, 2023
@jjonescz jjonescz closed this Jun 30, 2023
@jjonescz jjonescz deleted the 8718-MergeDuplicateDescriptors branch June 30, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-compiler Umbrella for all compiler issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blazor regression in 7.0.302 SDK
1 participant