Dig through nested csharp expressions for design time generation #8777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333fred
force-pushed
the
design-time-typeparam
branch
from
ae774cf to
db4ccfe
Compare
Fixes dotnet#8467. We weren't looking through nested expressions in design type for type parameters, which broke the `@typeparam` syntax for type parameter values.
333fred
force-pushed
the
design-time-typeparam
branch
from
db4ccfe to
5803279
Compare
|
Would #8572 be related? Might this fix that? |
|
No, that looks completely unrelated. That's a parsing issue, this is a designtime codegen issue. |
* upstream/main: (31 commits) Thread cancellation token Better criteria Add a debug assert for faults at debug time Do more work in setup Use ImmutableArray<T> in ProjectRazorJson Fix logic error in JsonDataWriter Tests Logging tweak Move file to the misc workspace when it is deleted, if it is open Use ImmutableArray<T> in ProjectWorkspaceState and IProjectSnapshot Reorganize files in MS.ANC.Razor.ProjectEngineHost Use ImmutableArray<T> in TagHelperResolutionResult and TagHelperDeltaResult Remove unused TagHelperResolutionResult.Diagnostics property Make JsonDataReader.ReadArray(...) methods consistent Clean up various JsonConverterCollectionExtensions classes Clean up ProjectSnapshotHandleProxyJsonConverter Clean up TagHelperResolutionResultJsonConverter Remove TagHelperDescriptorJsonConverter Clean up JsonConverterCollectionExtensions Clean up ProjectSnapshotHandleJsonConverter ...
|
@dotnet/razor-compiler for reviews please |
chsienki
approved these changes
Jun 2, 2023
|
@dotnet/razor-compiler for a second review. |
jjonescz
approved these changes
Jun 8, 2023
jjonescz
reviewed
Jun 8, 2023
...Microsoft.AspNetCore.Razor.Language/test/IntegrationTests/ComponentCodeGenerationTestBase.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8467. We weren't looking through nested expressions in design type for type parameters, which broke the
@typeparamsyntax for type parameter values.