Allow the Introduce local code action to run in code blocks #8830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Jun 15, 2023
| @@ -76,7 +76,7 @@ internal static class CodeActionExtensions | |||
|
|
|||
| if (!isOnAllowList) | |||
| { | |||
| razorCodeAction.Title = "(Exp) " + razorCodeAction.Title; | |||
| razorCodeAction.Title = $"(Exp) {razorCodeAction.Title} ({razorCodeAction.Name})"; | |||
There was a problem hiding this comment.
This is unrelated, but when experimenting with code actions, its handy to know what Roslyn calls the action so we know what to add to the allow list.
DustinCampbell
approved these changes
Jun 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8578
TL;DR: I added 4 tests per line of code, and I expect everyone of you to do the same from now on! 😛
This isn't perfect because cursor position after the code action can be questionable, and there is no way for us to trigger a rename of the introduced local after the code action executes, but neither of those things are possible to make any better with the current LSP spec and client implementations, so here we are. I basically just played around with this in VS with all of the possibilities I could think of, and couldn't break it, so I figure its better than not having the code action available.
Looks like this:
