Allow string code actions in Razor files #8837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Jun 16, 2023
| @@ -355,6 +355,15 @@ private static void CleanupSourceMappingStart(FormattingContext context, Range s | |||
| return; | |||
| } | |||
|
|
|||
| // Parent.Parent.Parent is because the tree is | |||
| // ExplicitExpression -> ExplicitExpressionBody -> CSharpCodeBlock -> CSharpExpressionLiteral | |||
| if (owner is CSharpExpressionLiteralSyntax { Parent.Parent.Parent: CSharpExplicitExpressionSyntax explicitExpression } && | |||
There was a problem hiding this comment.
This change is required because without code actions, there was no real way to invoke ontype formatting in an explicit expression, so there was just no code to deal with them.
davidwengier
commented
Jun 16, 2023
Comment on lines
+174
to
+176
| if (collapsedEdit.NewText.Length == 0 && | ||
| collapsedEdit.Range.Start.Line == collapsedEdit.Range.End.Line && | ||
| collapsedEdit.Range.Start.Character == collapsedEdit.Range.End.Character) |
There was a problem hiding this comment.
This change is required because otherwise the edit to remove the @ on @"goo" was being dropped. I've honestly no idea why we would have been filtering out empty edits, and can only guess that the intent was to filter out useless edits. No existing formatting tests break with this change, so we've got that going for us at least.
allisonchou
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: An inate desire to have more code actions