Make the latest configuration actually be somewhat recent #8906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Jul 4, 2023
| @@ -40,7 +40,11 @@ internal class FallbackRazorConfiguration : RazorConfiguration | |||
| "MVC-3.0", | |||
| new[] { new FallbackRazorExtension("MVC-3.0"), }); | |||
|
|
|||
| public static readonly RazorConfiguration Latest = MVC_3_0; | |||
| public static readonly RazorConfiguration Latest = new FallbackRazorConfiguration( | |||
There was a problem hiding this comment.
Does anyone know how "MVC versions" are expected to map to "Razor language versions"?
I can't tell if they are separate concepts, or this file is just old, and missing everything between 5 and 8. The MVC versions that are in this file seem to line up with RazorLanguageVersion entries.
ryzngard
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8572
I don't know why the fallback configuration is being used, so logged #8905 to investigate that further. This mitigates the problem though.