Remap and translate diagnostics on the server #9151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Aug 23, 2023
| @@ -191,6 +192,7 @@ public static void AddDocumentManagementServices(this IServiceCollection service | |||
| services.AddSingleton<GeneratedDocumentPublisher, DefaultGeneratedDocumentPublisher>(); | |||
| services.AddSingleton<IProjectSnapshotChangeTrigger>((services) => services.GetRequiredService<GeneratedDocumentPublisher>()); | |||
| services.AddSingleton<DocumentContextFactory, DefaultDocumentContextFactory>(); | |||
| services.AddSingleton(sp => new Lazy<DocumentContextFactory>(sp.GetRequiredService<DocumentContextFactory>)); | |||
There was a problem hiding this comment.
This is the annoying way to do lazy DI in this system, and its annoying, but I didn't think it was worth extracting new services and things, because ideally we can move to pull diagnostics in VS Code soon, and then the entire diagnostic publisher can be deleted.
davidwengier
commented
Aug 23, 2023
| @@ -29,7 +30,6 @@ internal static class CustomMessageNames | |||
| public const string RazorResolveCodeActionsEndpoint = "razor/resolveCodeActions"; | |||
| public const string RazorProvideHtmlColorPresentationEndpoint = "razor/provideHtmlColorPresentation"; | |||
| public const string RazorProvideHtmlDocumentColorEndpoint = "razor/provideHtmlDocumentColor"; | |||
| public const string RazorPullDiagnosticEndpointName = "razor/pullDiagnostics"; | |||
There was a problem hiding this comment.
Previously VS and VS Code both used this method name, but to my surprise, with different response types. Not strictly an issue since the two systems never exist together, but I thought it would be easier to audit things in future if it wasn't confusing.
ryzngard
approved these changes
Aug 23, 2023
| @@ -193,8 +209,8 @@ internal async Task PublishDiagnosticsAsync(IDocumentSnapshot document) | |||
| { | |||
| var result = await document.GetGeneratedOutputAsync().ConfigureAwait(false); | |||
There was a problem hiding this comment.
nit: Move this below the if next to where it's used
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Server side of dotnet/vscode-csharp#6209
Found an issue in the logs where 2 seconds after a .razor document close, we try to update diagnostics for the document, which then tries to remap the ranges for those diagnostics, but we've just closed the file, the so it fails. This was actually quite wasteful, as the remapping has to happen on the server anyway, so its better to just do it after the results have come back. Additionally, it meant that VS Code diagnostics weren't going through our translation service, which excludes some diagnostics and fixes ranges on others, so the experience would have been generally worse than in VS.
Also renamed a couple of things to make a bit more sense, so the changes are slightly bigger than they first seem.