Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add compiler support for @formname attribute #9153

Merged
merged 3 commits into from
Sep 1, 2023
Merged

Add compiler support for @formname attribute #9153

merged 3 commits into from
Sep 1, 2023

Conversation

jjonescz
Copy link
Member

Resolves #9077.

@jjonescz jjonescz added the area-compiler Umbrella for all compiler issues label Aug 23, 2023
@jjonescz jjonescz marked this pull request as ready for review August 23, 2023 15:03
@jjonescz jjonescz requested a review from a team as a code owner August 23, 2023 15:04
333fred
333fred reviewed Aug 23, 2023
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done review pass

...Compiler/Microsoft.AspNetCore.Razor.Language/src/Components/ComponentFormNameLoweringPass.cs Show resolved Hide resolved
...Compiler/Microsoft.AspNetCore.Razor.Language/src/Components/ComponentFormNameLoweringPass.cs Show resolved Hide resolved
src/Compiler/Microsoft.AspNetCore.Razor.Language/src/Components/ComponentNodeWriter.cs Outdated Show resolved Hide resolved
src/Compiler/Microsoft.AspNetCore.Razor.Language/src/Components/ScopeStack.cs Outdated Show resolved Hide resolved
...Compiler/Microsoft.AspNetCore.Razor.Language/src/Components/TagHelperDescriptorExtensions.cs Show resolved Hide resolved
...mpiler/Microsoft.AspNetCore.Razor.Language/src/Intermediate/MarkupElementIntermediateNode.cs Outdated Show resolved Hide resolved
...t.AspNetCore.Razor.Test.Common/Language/IntegrationTests/RazorBaselineIntegrationTestBase.cs Show resolved Hide resolved
@jjonescz @333fred
Improve code style
77e28c1 
Co-authored-by: Fred Silberberg <fred@silberberg.xyz>
@jjonescz jjonescz mentioned this pull request Aug 24, 2023
Merged
@jjonescz jjonescz requested a review from 333fred August 24, 2023 08:32
333fred
333fred approved these changes Aug 24, 2023
View reviewed changes
Copy link
Member

@333fred 333fred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 2), but I did have a comment on the common refactoring in #9158.

@jjonescz jjonescz requested a review from chsienki August 25, 2023 08:00
@jaredpar
Copy link
Member

@chsienki for second review

@jjonescz jjonescz merged commit 4ce8280 into dotnet:main Sep 1, 2023
@jjonescz jjonescz deleted the 9077-formname branch September 1, 2023 07:58
@ghost ghost added this to the Next milestone Sep 1, 2023
@allisonchou allisonchou mentioned this pull request Sep 5, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chsienki chsienki chsienki approved these changes

@333fred 333fred 333fred approved these changes

Assignees

@chsienki chsienki

Labels
area-compiler Umbrella for all compiler issues
Projects
None yet
Milestone
17.8
Development

Successfully merging this pull request may close these issues.

Add Razor compiler support for the @formname attribute
5 participants
@jjonescz @jaredpar @333fred @chsienki @Cosifne