Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration Tests #9163

Merged
merged 4 commits into from
Aug 28, 2023
Merged

Integration Tests #9163

merged 4 commits into from
Aug 28, 2023

Conversation

davidwengier
Copy link
Contributor

@davidwengier davidwengier commented Aug 24, 2023 •
edited
Loading

  • Improved our general integration test strategy of making changes to projects and things, and hoping for the best.
    • We now wait for our project system to know about projects and files we add before we try to open them
    • We now wait for our document management system to know about open files before we try to test features with them
  • Slightly un-reverted the Debug.Fail behaviour
    • Environment.FailFast was annoying, and didn't have nice failure messages, so now we capture the messages and fail the test at the end if there was one, which works around issues with test runners, proxies, etc.

@davidwengier davidwengier changed the title Fail test if a Debug.Fail call happens Integration Tests Aug 25, 2023
@davidwengier davidwengier marked this pull request as ready for review August 25, 2023 07:08
@davidwengier davidwengier requested a review from a team as a code owner August 25, 2023 07:08
@davidwengier
Copy link
Contributor Author

/azp run

@dotnet dotnet deleted a comment from azure-pipelines bot Aug 25, 2023
@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@davidwengier davidwengier enabled auto-merge August 25, 2023 11:17
@davidwengier davidwengier disabled auto-merge August 25, 2023 11:27
@davidwengier davidwengier mentioned this pull request Aug 25, 2023
Closed
1 task
@davidwengier davidwengier merged commit 909a118 into dotnet:main Aug 28, 2023
@davidwengier davidwengier deleted the FailTestOnDebugFail branch August 28, 2023 22:19
@ghost ghost added this to the Next milestone Aug 28, 2023
@allisonchou allisonchou mentioned this pull request Sep 5, 2023
Closed
@Cosifne Cosifne modified the milestones: Next, 17.8 P3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allisonchou allisonchou allisonchou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
17.8
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwengier @allisonchou @Cosifne