Fix C# background color bug when using tab indentation #9257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwengier
commented
Sep 8, 2023
| @@ -70,6 +70,10 @@ internal class RazorSemanticTokensInfoService : IRazorSemanticTokensInfoService | |||
| { | |||
| csharpSemanticRanges = await GetCSharpSemanticRangesAsync(codeDocument, textDocumentIdentifier, range, razorSemanticTokensLegend, documentContext.Version, correlationId, cancellationToken).ConfigureAwait(false); | |||
| } | |||
| catch (OperationCanceledException) | |||
There was a problem hiding this comment.
Noticed in the logs we were reporting this as an issue, when its totally normal, and in fact it should probably happen a little more than it does now!
| // Weren't able to re-invoke C# semantic tokens but we have to indicate it's due to out of sync by providing the old version | ||
| return new ProvideSemanticTokensResponse(tokens: null, hostDocumentSyncVersion: csharpDoc.HostDocumentSyncVersion ?? -1); | ||
| } | ||
|
|
||
| _logger?.LogDebug("Made {count} semantic tokens requests to Roslyn", semanticTokensParams.Ranges.Length); |
There was a problem hiding this comment.
Snuck this one in too, so we can see what is going on with our new feature flag.
allisonchou
approved these changes
Sep 8, 2023
| @@ -230,7 +230,7 @@ private static bool ContainsOnlySpacesOrTabs(SourceText razorSource, int startIn | |||
| var end = startIndex + count; | |||
| for (var i = startIndex; i < end; i++) | |||
| { | |||
| if (razorSource[i] is not ' ' or '\t') | |||
| if (razorSource[i] is not (' ' or '\t')) | |||
There was a problem hiding this comment.
This is subtle, nice catch!
There was a problem hiding this comment.
Would have been nicer to catch it when I wrote the code in the first place. Not the first time I've made this mistake either 🤦🏼♂️
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while testing with a customer solution.
Commit-at-a-time to make the difference in the test baseline visible with the bug fix.