Avoid using AddComponentParameter in design time
#9265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at the difference in codegen, and the complete lack of source mapping or validation of user code, I'm not sure either has a benefit in design time, but probably best not to rock the boat too much 😁 |
chsienki
approved these changes
Sep 11, 2023
|
@333fred @dotnet/razor-compiler for a second review, thanks |
jaredpar
approved these changes
Sep 12, 2023
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AB#1869483.
I think using
AddComponentParameteroverAddAttributehas no benefit in design time (the motivation for introduction of the method were runtime errors, see #8258) so avoiding it unconditionally in design time should be the safest fix.