Features/rendermode #9277
Merged
Features/rendermode #9277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Basic support for components specifying render modes
Implement @rendermode attributes
* Explicit render mode error - Make it an error to specify a @rendermode attribute on a component that declares an explicit @rendermode directive * Add docs for rendermode attribute * Remove hard coded doc strings for rendermode directive * Swap prototype comment for issue link * Wording / formatting
* Implement expression version of @rendermode directive
* Restore to previous lowering mechansim * Use global and fully typed name on attribute * Rename generated attribute to have prefix * Fix design time directives
Merges main into the feature branch. Merge was mostly clean, just combining the rendermode and formname additions. I've added comments to the less obvious merge resolutions (diagnostic numbers and a parsing fix), but it was generally very simple.
|
@dotnet/razor-compiler for review please. |
jaredpar
approved these changes
Sep 12, 2023
ghost
modified the milestones:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge rendermode feature to main. Code flow only PR.
We'll do a feature/test plan review later this week, but want to get it merged to ensure we have enough time for RC2 codeflow to AspNetCore