Further reduce allocations in semantic tokens #9285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing Range and Position for now. TextEdit might be worth it later
I expect some calls won't make sense to update so these might stay around, or maybe they'll just be temporary. Who knows!
This also includes some consolidation, so SourceTextExtensions is the only thing that does the work, so everything is LSP compliant
With the help of a few new helper methods
|
This looks really good to me. I'm going to defer to someone on the razor team for actual signoff though. |
DustinCampbell
approved these changes
Sep 14, 2023
src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/Extensions/LinePositionExtensions.cs
Show resolved
Hide resolved
maryamariyan
approved these changes
Sep 14, 2023
ghost
added this to the 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #9280
This creates a struct based API for document mapping, and moves semantic tokens to it. I did it in a source-compatible way so we can upgrade existing features as necessary. I suspect most won't get the benefit that semantic tokens gets, as most things just ferry ranges and positions around, and don't process them much. Logged #9284 to follow up though.
Commit-at-a-time might be easiest.
Results for semantic tokens are pretty good though:
