Allow render mode attribute to be null #9400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/razor-compiler for review please |
|
Should this target |
jjonescz
reviewed
Oct 12, 2023
...Microsoft.AspNetCore.Razor.Language/test/IntegrationTests/ComponentCodeGenerationTestBase.cs
Outdated
Show resolved
Hide resolved
...ionTests/ComponentDesignTimeCodeGenerationTest/RenderMode_With_Null/TestComponent.codegen.cs
Outdated
Show resolved
Hide resolved
chsienki
force-pushed
the
nullable_render_mode
branch
from
7f59655 to
aea9601
Compare
jjonescz
approved these changes
Oct 13, 2023
|
@333fred for a second review please :) |
333fred
approved these changes
Oct 13, 2023
halter73
approved these changes
Oct 19, 2023
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
333fred
added a commit
to 333fred/razor
that referenced
this pull request
Oct 20, 2023
* upstream/main: (78 commits) Convert RazorSourceDocument to a SourceText + FileName (dotnet#8933) Allow render mode attribute to be null (dotnet#9400) Update dependencies from https://github.com/dotnet/arcade build 20231018.2 Don't report that we're synchronized if the line count is wrong Update dependencies from https://github.com/dotnet/arcade build 20231017.7 (dotnet#9435) Guess what! I've got a fever, and the only prescription is more usings! Replace explicit richCodeNavigationEnvironment in azure-pipelines-richnav.yml Change constraint to require that T inherit from TagHelperCollector<T> Update dependencies from https://github.com/dotnet/arcade build 20231016.5 Found a repro, made a test! Don't map to ranges that are invalid Don't run conditional tests on PRs (dotnet#9416) Update dependencies from https://github.com/dotnet/source-build-reference-packages build 20231010.3 Update dependencies from https://github.com/dotnet/arcade build 20231010.4 Don't bother looking up ever project if we know where it comes from Make sure we carry ProjectContext through to code action resolve Localized file check-in by OneLocBuild Task: Build definition ID 262: Build ID 2291545 Return an incomplete list if the delegated server doesn't respond Update dependencies from https://github.com/dotnet/arcade build 20231010.4 Update dependencies from https://github.com/dotnet/arcade build 20231010.4 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes code gen to only emit only the user expression portion of the render mode into a
#nullable restorecontext.Fixes #9343