[FUSE] Add some missing runtime source mappings #9883
Conversation
|
@dotnet/razor-compiler for reviews please. //cc @ryzngard |
chsienki
force-pushed
the
runtime_line_pragmas
branch
from
ecd402a
to
9650db1
Compare
| |using System.Threading.Tasks | ||
| | | ||
| Generated Location: (317:11,0 [30] ) | ||
| |using System.Threading.Tasks;| |
There was a problem hiding this comment.
The source location has a newline as the last character while the generated location has a semicolon there instead. Perhaps the mapping should be one character shorter?
I wonder if we should assert that source and generated location texts match so we don't have to check this manually.
There was a problem hiding this comment.
The generated location also includes a semi-colon. I think this would be a problem, yes.
I wonder if we should assert that source and generated location texts match
I thought there was such a validation, maybe its just not called in all cases. Pretty sure I've hit it once or twice.
There was a problem hiding this comment.
Oh huh, good catch. I'll add the assertion if we don't have it, too.
There was a problem hiding this comment.
So, it turns out fixing the using discrepancy is significantly more involved, as it's actually a difference in parsing that's occurring.
I've backed out the using mappings from this PR, rather than try and fix a huge amount of stuff in one go.
Add various line mappings that are missing in runtime documents.
Commits are split between changes and baseline updates; suggest reviewing separately.
Still have more mappings to be added, but they are more involved so submitting this in parts.
Fixes #9828
Before:
After:
