Add netstandard2.0 target to AsyncRx.NET #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1954
NOTE: it is not yet clear whether this is going to work, because we don't currently know why the project didn't do this to begin with.
It's true that
netstandard2.0doesn't include theIAsyncEnumerable<T>,IAsyncEnumerator<T>, andIAsyncDisposableinterfaces, but these are available through theMicrosoft.Bcl.AsyncInterfacesNuGet package. Perhaps that wasn't available when this code was first written. But there might be some deeper problem. (And since this project doesn't yet have a test suite, we can't be confident in changes like this.)If @bartdesmet happens to spot this, it would be great to know whether there's some good reason we can't just use that NuGet package to get ourselves a
netstandard2.0-compatible package.So this is currently an experimental feature.