CA1801 false positive on record with property-targeting attribute on parameter

[huoyaoyuan]

Analyzer

Diagnostic ID: CA1801: Review unused parameters

Analyzer source

SDK: Built-in CA analyzers in .NET 5 SDK or later

Version: SDK 5.0.100-rc.2

Describe the bug

    public sealed record AuthProfileImageUrls(
        [property: JsonPropertyName("px_16x16")]
        Uri PixelSize16,
        [property: JsonPropertyName("px_50x50")]
        Uri PixelSize50,
        [property: JsonPropertyName("px_170x170")]
        Uri PixelSize170);

If any of the parameters have a [property: attribute, then CA1801 will fire on all parameters.

Additional context

I wonder the relationship between CA1801 and IDE0060. IDE0060 used to fire a false positive on this, but get fixed later. Once IDExxxx analyzers are available in CLI builds, I will consider to use IDE0060 to replace CA1801.

[mavasani]

Once IDExxxx analyzers are available in CLI builds, I will consider to use IDE0060 to replace CA1801.

They are available in CLI. Please see https://docs.microsoft.com/dotnet/fundamentals/code-analysis/overview#code-style-analysis

[billybraga]

How can we be alerted when this is released ? It's included in roslyn-analyzers 5.0.3, but .NET SDK 5.0.201 (most recent) ships with version 5.0.2 of roslyn-analyzers.

[jmarolf]

this is not going to be ported to the 5.0.2xx SDKs but will appear in 5.0.3xx

[billybraga]

I'm still having this issue in 5.0.203

[Sharparam]

Having this issue on 5.0.400, which is strange considering it was going to be included in 5.0.3xx?

[dlouwers]

Also having this on records with default parameters, 5.0.400

[dlouwers]

Workaround:
public record MyRecord(string P1 = null, string P2 = null);

to

public record MyRecord
{
  public string P1 { get; init; }
  public string P2 { get; init; }

  public MyRecord(string p1 = null, string p2 = null)
  {
    P1 = p1;
    P2 = p2;
  }
}

Very verbose and hope this false positive will be fixed so think it is better to suppress for now.

[AlbertoMonteiro]

@dlouwers I think that using that way is much simplier

#pragma warning disable CA1801
public sealed record AuthProfileImageUrls(
    [property: JsonPropertyName("px_16x16")] Uri PixelSize16,
    [property: JsonPropertyName("px_50x50")] Uri PixelSize50,
    [property: JsonPropertyName("px_170x170")] Uri PixelSize170);

[chibanemourad]

I have the same problem (CA1801 false positive) with sdk version 5.0.402 :

public abstract record ATest(int Id, string Name);

public record ConcreteTest(int Id, string Name, State state) : ATest(Id, Name);