Fix CA1801 false positive with positional records primary ctor #4499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
commented
Dec 4, 2020
...harp/Microsoft.CodeQuality.Analyzers/Maintainability/CSharpReviewUnusedParametersAnalyzer.cs
Show resolved
Hide resolved
Youssef1313
reviewed
Dec 4, 2020
...ers/UnitTests/Microsoft.CodeQuality.Analyzers/Maintainability/ReviewUnusedParametersTests.cs
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Dec 4, 2020
src/NetAnalyzers/Core/Microsoft.CodeQuality.Analyzers/Maintainability/ReviewUnusedParameters.cs
Outdated
Show resolved
Hide resolved
Evangelink
changed the title
|
@Evangelink There are still build failures. You will need to run |
mavasani
approved these changes
Dec 4, 2020
|
@Evangelink I think you can target master and the build error should go away by itself. |
Evangelink
commented
Dec 7, 2020
Codecov Report
@@ Coverage Diff @@
## master #4499 +/- ##
=======================================
Coverage 95.84% 95.85%
=======================================
Files 1175 1177 +2
Lines 268047 268104 +57
Branches 16174 16182 +8
=======================================
+ Hits 256921 256979 +58
+ Misses 9068 9055 -13
- Partials 2058 2070 +12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #4476 and fix #4462 and fix #4397