Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression in avoid multiple enumerations analyzer #6830

Closed
mavasani opened this issue Aug 2, 2023 · 0 comments · Fixed by #6834
Closed

Fix regression in avoid multiple enumerations analyzer #6830

mavasani opened this issue Aug 2, 2023 · 0 comments · Fixed by #6834

Comments

@mavasani
Copy link
Contributor

mavasani commented Aug 2, 2023

PR #6828 causes couple of tests to fail in Avoid multiple enumerations analyzer (CA1851):

  • TestDomainMerge
  • TestInvocationsInForEachLoop

There likely needs to be some follow-up changes in the analyzer OR it's flow analysis component to fix these. This issue will be used to skip these tests and unskip when fixed
mavasani added a commit to mavasani/roslyn-analyzers that referenced this issue Aug 4, 2023
@mavasani
Skip exceptions path analysis post pass for global flow analysis
8c0c7b6 
Closes dotnet#6833
Closes dotnet#6830
mavasani added a commit to mavasani/roslyn-analyzers that referenced this issue Aug 4, 2023
@mavasani
Skip exceptions path analysis post pass for global flow analysis
4db12d1 
Closes dotnet#6833
Closes dotnet#6830
mavasani added a commit to mavasani/roslyn-analyzers that referenced this issue Aug 4, 2023
@mavasani
Skip exceptions path analysis post pass for global flow analysis
7d9ab11 
Closes dotnet#6833
Closes dotnet#6830
@mavasani mavasani mentioned this issue Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip exceptions path analysis post pass for global flow analysis mavasani/roslyn-analyzers
1 participant
@mavasani