Disable problematic analyzer CA1801 #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📝 I haven't been able to test this yet, but I suspect the usability problem with the light bulb is caused by this exception. |
mavasani
approved these changes
Apr 7, 2017
|
@sharwell I am going to merge this in. |
jinujoseph
pushed a commit
to jinujoseph/roslyn-analyzers
that referenced
this pull request
May 22, 2017
This reverts commit 9baeaad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CA1801 is causing false positives, and
the code fix rendersthe light bulb is unusable when this occurs. This pull request disables the analyzer until the known problems can be corrected.Edit: I'm not certain the code fix is the cause of the light bulb usability problem, but its implementation is suspect.