Port "DiagnosticDescriptor id fix" #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReadonlyMethodGroupAllocationRule is using a name in the DiagnosticDescriptor id field, this corrects it to use an actual id. This is ported from microsoft/RoslynClrHeapAllocationAnalyzer#76
mavasani
approved these changes
Feb 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #3269 +/- ##
==========================================
- Coverage 95.23% 95.23% -0.01%
==========================================
Files 978 978
Lines 221212 221212
Branches 14229 14229
==========================================
- Hits 210665 210664 -1
Misses 8923 8923
- Partials 1624 1625 +1 |
sharwell
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReadonlyMethodGroupAllocationRule is using a name in the DiagnosticDescriptor id field, this corrects it to use an actual id.
This is ported from microsoft/RoslynClrHeapAllocationAnalyzer#76. Originally commited by @nnpcYvIVl
FYI @mjsabby