Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer + Fixer: Forward cancellation token to method invocations #3641

Merged
merged 20 commits into from
Jun 22, 2020
Merged

Analyzer + Fixer: Forward cancellation token to method invocations #3641

merged 20 commits into from
Jun 22, 2020

Commits on Jun 10, 2020

  1. Analyzer + Fixer: Forward cancellation token to async methods

    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    9d71274 View commit details
    Browse the repository at this point in the history

  2. Address PR suggestions: 

    - Do not limit to only await. Detect all invocations.
- Fix the resource messages.
- Fix some warnings.
    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    4cc0fba View commit details
    Browse the repository at this point in the history

  3. Address case where CancellationToken is an aliased using

    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    084dc36 View commit details
    Browse the repository at this point in the history

  4. Address PR suggestions

    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    5bfb7d8 View commit details
    Browse the repository at this point in the history

  5. Fix breaking change introduced by most recent rebased changes.

    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    efa1838 View commit details
    Browse the repository at this point in the history

  6. Address PR suggestions

    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    4c5776d View commit details
    Browse the repository at this point in the history

  7. Address named argument problem in C#, add two cases with diagnostics … 

    …but no fix.
    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    981095f View commit details
    Browse the repository at this point in the history

  8. Offer diagnostic only on the invocation expression name.

    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    9b86720 View commit details
    Browse the repository at this point in the history

  9. Bail out early in fixer before registering code fix

    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    8b32db5 View commit details
    Browse the repository at this point in the history

  10. address analyzer attributes in wrong locations

    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    f776fbb View commit details
    Browse the repository at this point in the history

  11. Fix newest edge cases except lambda that does not take token

    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    e809c9a View commit details
    Browse the repository at this point in the history

  12. Address last false positives, add trivia support

    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    d08aada View commit details
    Browse the repository at this point in the history

  13. Fix comment formatting warning

    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    6cc2cc7 View commit details
    Browse the repository at this point in the history

  14. Additional case for ct params

    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    f4b4bdd View commit details
    Browse the repository at this point in the history

  15. Added more edge cases, ensured to do the most basic check at the begi… 

    …nning
    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    d5ddc40 View commit details
    Browse the repository at this point in the history

  16. Add method extension unit test

    @carlossanlop
    carlossanlop committed Jun 10, 2020
    Configuration menu
    Copy the full SHA
    b5a3fd6 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2020

  1. Address suggestions and more edge cases

    @carlossanlop
    carlossanlop committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    4061840 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2020

  1. Address latest suggestions, fixed one VB case where extension method … 

    …parameters were not detected correctly
    @carlossanlop
    carlossanlop committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    8b2f0dc View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. Address latest suggestions

    @carlossanlop
    carlossanlop committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    9167229 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2020

  1. Address last suggestions

    @carlossanlop
    carlossanlop committed Jun 22, 2020
    Configuration menu
    Copy the full SHA
    d5af47e View commit details
    Browse the repository at this point in the history