Do not report CA1307 for known non-string comparisons #4035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#2581 When we know that a comparison is between a string type receiver and a non-string type parameter, do not report CA1307
dotpaul
reviewed
Aug 18, 2020
src/NetAnalyzers/UnitTests/Microsoft.NetCore.Analyzers/Runtime/SpecifyStringComparisonTests.cs
Show resolved
Hide resolved
|
Thanks! |
Codecov Report
@@ Coverage Diff @@
## master #4035 +/- ##
========================================
Coverage 95.63% 95.63%
========================================
Files 1156 1156
Lines 256439 256670 +231
Branches 15354 15367 +13
========================================
+ Hits 245238 245464 +226
- Misses 9242 9247 +5
Partials 1959 1959 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2581
When we know that a comparison is between a string type receiver and a non-string type parameter OR that the method is not a string comparison method, do not report CA1307.