Separate out CA1307 into two rules #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dotnet#2581, again! 1. CA1310: Correctness rule that only flags string compare methods that are known to use culture specific string comparison by default 2. CA1307: Maintainability/Readability rule that flags the remainder methods that have an overload with an additional StringComparison parameter at the end. This rule does not care about the defaault string comparison used by the API.
Codecov Report
@@ Coverage Diff @@
## master #4043 +/- ##
==========================================
- Coverage 95.63% 95.63% -0.01%
==========================================
Files 1156 1156
Lines 256670 256749 +79
Branches 15367 15370 +3
==========================================
+ Hits 245474 245549 +75
- Misses 9242 9243 +1
- Partials 1954 1957 +3 |
|
Thanks @dotpaul |
|
Filed https://github.com/MicrosoftDocs/visualstudio-docs/issues/5754 for adding docs. |
|
Doesn't this mean that CA1307 will now always fire on |
|
Yes, if you only care about correctness, you should disable CA1307 and just enable CA1310. CA1307 would most likely be used like a refactoring/hidden/suggestion available in IDE for users where they want to opportunistically keep moving to API overloads with StringComparison parameter. |
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2581, again!
CA1310: Correctness rule that only flags string compare methods that are known to use culture specific string comparison by defaultCA1307: Maintainability/Readability rule that flags the remainder methods that have an overload with an additional StringComparison parameter at the end. This rule does not care about the default string comparison used by the API.