Fix bug when exception declared in filter is thrown #4285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Evangelink
approved these changes
Oct 3, 2020
...zers/Core/Microsoft.CodeQuality.Analyzers/QualityGuidelines/RethrowToPreserveStackDetails.cs
Outdated
Show resolved
Hide resolved
Youssef1313
commented
Oct 3, 2020
...zers/Core/Microsoft.CodeQuality.Analyzers/QualityGuidelines/RethrowToPreserveStackDetails.cs
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #4285 +/- ##
========================================
Coverage 95.80% 95.81%
========================================
Files 1168 1168
Lines 264635 264966 +331
Branches 15964 15974 +10
========================================
+ Hits 253539 253879 +340
+ Misses 9078 9076 -2
+ Partials 2018 2011 -7 |
mavasani
reviewed
Oct 3, 2020
| @@ -49,7 +49,8 @@ public override void Initialize(AnalysisContext analysisContext) | |||
| if (ancestor.Kind == OperationKind.CatchClause && | |||
| ancestor is ICatchClauseOperation catchClause) | |||
| { | |||
| if (catchClause.Locals.Contains(localReference.Local) && | |||
| if ((catchClause.ExceptionDeclarationOrExpression is not IVariableDeclaratorOperation variableDeclaratorOperation || SymbolEqualityComparer.Default.Equals(variableDeclaratorOperation.Symbol, localReference.Local)) && | |||
There was a problem hiding this comment.
Why are we skipping the check if this not a variable declaration?
Suggested change
| if ((catchClause.ExceptionDeclarationOrExpression is not IVariableDeclaratorOperation variableDeclaratorOperation || SymbolEqualityComparer.Default.Equals(variableDeclaratorOperation.Symbol, localReference.Local)) && | |
| if (catchClause.ExceptionDeclarationOrExpression is IVariableDeclaratorOperation variableDeclaratorOperation && SymbolEqualityComparer.Default.Equals(variableDeclaratorOperation.Symbol, localReference.Local) && |
mavasani
reviewed
Oct 3, 2020
...ests/Microsoft.CodeQuality.Analyzers/QualityGuidelines/RethrowToPreserveStackDetailsTests.cs
Show resolved
Hide resolved
mavasani
reviewed
Oct 3, 2020
...ests/Microsoft.CodeQuality.Analyzers/QualityGuidelines/RethrowToPreserveStackDetailsTests.cs
Show resolved
Hide resolved
mavasani
approved these changes
Oct 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4280