Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't guard Dictionary<K, V>.Remove(key) by ContainsKey(key) #4836

Merged
merged 47 commits into from
Apr 29, 2022
Merged

Don't guard Dictionary<K, V>.Remove(key) by ContainsKey(key) #4836

merged 47 commits into from
Apr 29, 2022

Commits on Sep 5, 2021

  1. Early stab at #33797 Don't guard Dictionary<K, V>.Remove(key) by Cont… 

    …ainsKey(key)

Diagnostic analyzer only; no CodeFixProvider yet
    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    7245b4e View commit details
    Browse the repository at this point in the history

  2. Fix VB tests

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    17f1053 View commit details
    Browse the repository at this point in the history

  3. Implement and test a single-statement block

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    06c0391 View commit details
    Browse the repository at this point in the history

  4. Assign the correct rule ID, fix whitespace, add a comment

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    6fe0b87 View commit details
    Browse the repository at this point in the history

  5. Added a CodeFixProvider/CodeAction

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    30bf3d7 View commit details
    Browse the repository at this point in the history

  6. Apply suggestions from code review 

    Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
    @chucker @Youssef1313
    2 people authored and Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    b344987 View commit details
    Browse the repository at this point in the history

  7. Apply more suggestions from code review

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    6a2806b View commit details
    Browse the repository at this point in the history

  8. We don't need {|#0: |} notation if we only have one rule

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    bb61880 View commit details
    Browse the repository at this point in the history

  9. The fixed source doesn't have diagnostics

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    cd81756 View commit details
    Browse the repository at this point in the history

  10. Use DocumentChangeAction and replaces nodes instead of editing text

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    ede496c View commit details
    Browse the repository at this point in the history

  11. formatting; re-ran 'pack' target

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    d78addf View commit details
    Browse the repository at this point in the history

  12. removed obsolete code

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    9041727 View commit details
    Browse the repository at this point in the history

  13. Fixer should have a title distinct from analyzer

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    7edc5df View commit details
    Browse the repository at this point in the history

  14. Apply suggestions from code review 

    Co-authored-by: Amaury Levé <amaury.leve@gmail.com>
    @chucker @Evangelink
    2 people authored and Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    5f97bf3 View commit details
    Browse the repository at this point in the history

  15. Additional tests

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    46621be View commit details
    Browse the repository at this point in the history

  16. Update src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/Performance/… 

    …DoNotGuardDictionaryRemoveByContainsKey.cs

Co-authored-by: Youssef Victor <31348972+Youssef1313@users.noreply.github.com>
    @chucker @Youssef1313
    2 people authored and Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    6055450 View commit details
    Browse the repository at this point in the history

  17. Inline calls to CreateResource

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    accc0bd View commit details
    Browse the repository at this point in the history

  18. Mark the rule as unnecessary, to fade it out in the IDE

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    916f0e3 View commit details
    Browse the repository at this point in the history

  19. Simplify/generalize name of fixer action

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    513a6af View commit details
    Browse the repository at this point in the history

  20. Fixed a dumb regression (all strings were empty) from f01cb8b

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    704f32e View commit details
    Browse the repository at this point in the history

  21. Simplified the description

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    2a8fc92 View commit details
    Browse the repository at this point in the history

  22. Added HasElseBlock_NoDiagnostic_CS test

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    e4f50eb View commit details
    Browse the repository at this point in the history

  23. Register the conditional instead of the invocation inside the condition

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    bca7332 View commit details
    Browse the repository at this point in the history

  24. Test Remove() with out param

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    26f6f3e View commit details
    Browse the repository at this point in the history

  25. For additional statements, warn (but don't offer a fix)

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    cce22c2 View commit details
    Browse the repository at this point in the history

  26. NegatedCondition_NoDiagnostic_CS now reports a diagnostic; also porte… 

    …d to VB
    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    7d97c6a View commit details
    Browse the repository at this point in the history

  27. Preserve trivia (e.g., code comments)

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    eb84634 View commit details
    Browse the repository at this point in the history

  28. fixed a unit test regression due to incorrect whitespace

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    47bfc85 View commit details
    Browse the repository at this point in the history

  29. if there's an else block, but the if block _only_ contains Remove, ne… 

    …gate the condition and remove the old if block
    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    e82a37d View commit details
    Browse the repository at this point in the history

  30. Bumped rule ID to 1849

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    f15f370 View commit details
    Browse the repository at this point in the history

  31. Newer file headers

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    b49cbf6 View commit details
    Browse the repository at this point in the history

  32. Re-ran /t:pack

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    03136aa View commit details
    Browse the repository at this point in the history

  33. invocationOperation might be null

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    7a6af81 View commit details
    Browse the repository at this point in the history

  34. Fix IDE0073

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    1e75911 View commit details
    Browse the repository at this point in the history

  35. AnalyzerReleases.Unshipped.md is apparently being generated incorrectly?

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    7b6917a View commit details
    Browse the repository at this point in the history

  36. Add a test for 5c8c8fe

    Sören Kuklau committed Sep 5, 2021
    Configuration menu
    Copy the full SHA
    a952e90 View commit details
    Browse the repository at this point in the history

Commits on Feb 1, 2022

  1. Merge conflicts

    @buyaa-n
    buyaa-n committed Feb 1, 2022
    Configuration menu
    Copy the full SHA
    2c9d717 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. Apply feedbacks, restrict to Dictionary type methods

    @buyaa-n
    buyaa-n committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    67e3398 View commit details
    Browse the repository at this point in the history

  2. Merge conflicts

    @buyaa-n
    buyaa-n committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    7fc1933 View commit details
    Browse the repository at this point in the history

  3. Fix build errors

    @buyaa-n
    buyaa-n committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    7bb8646 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2022

  1. Apply feedback

    @buyaa-n
    buyaa-n committed Feb 4, 2022
    Configuration menu
    Copy the full SHA
    45fea08 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. Merge conflicts

    @buyaa-n
    buyaa-n committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    0d93a8d View commit details
    Browse the repository at this point in the history

  2. Typo

    @buyaa-n
    buyaa-n committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    3ddac4c View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2022

  1. Apply feedbacks

    @buyaa-n
    buyaa-n committed Apr 27, 2022
    3 Configuration menu
    Copy the full SHA
    191c334 View commit details
    Browse the repository at this point in the history

  2. Merge conflicts

    @buyaa-n
    buyaa-n committed Apr 27, 2022
    Configuration menu
    Copy the full SHA
    63fc959 View commit details
    Browse the repository at this point in the history

  3. Update with new ID and regenerate files

    @buyaa-n
    buyaa-n committed Apr 27, 2022
    1 Configuration menu
    Copy the full SHA
    d91f724 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2022

  1. Apply feedback, make remove2Param optional

    @buyaa-n
    buyaa-n committed Apr 28, 2022
    Configuration menu
    Copy the full SHA
    1078915 View commit details
    Browse the repository at this point in the history