Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend using Equals with StringComparison instead of string.ToLower() == otherString.ToLower() #6720

Merged
merged 12 commits into from
Jul 26, 2023
Merged

Recommend using Equals with StringComparison instead of string.ToLower() == otherString.ToLower() #6720

merged 12 commits into from
Jul 26, 2023

Commits on Jul 17, 2023

  1. Analyzer: Use string.Format with CultureInfo for title.

    @carlossanlop
    carlossanlop committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    7cc2e29 View commit details
    Browse the repository at this point in the history

  2. Almost, only needs to handle inequality

    @carlossanlop
    carlossanlop committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    842a82f View commit details
    Browse the repository at this point in the history

  3. Fix inequality case, fix trivia, still need to add C# test

    @carlossanlop
    carlossanlop committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    a344cc6 View commit details
    Browse the repository at this point in the history

  4. Add C# tests for trivia and string method

    @carlossanlop
    carlossanlop committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    8d5e8ec View commit details
    Browse the repository at this point in the history

  5. Add tests for diagnostic-only, no fix, for Equals that don't match va… 

    …riant/invariant.
    @carlossanlop
    carlossanlop committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    fa70b2e View commit details
    Browse the repository at this point in the history

  6. Use ValueTuple in tests

    @carlossanlop
    carlossanlop committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    044aedc View commit details
    Browse the repository at this point in the history

  7. Register operation actions separately.

    @carlossanlop
    carlossanlop committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    adfcc80 View commit details
    Browse the repository at this point in the history

  8. Fix recent nullability changes

    @carlossanlop
    carlossanlop committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    4e17f73 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Use simplified valuetuple creation in tests

    @carlossanlop
    carlossanlop committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    13b8d47 View commit details
    Browse the repository at this point in the history

  2. Add extra rule and resource messages for the 'string.Method() == stri… 

    …ng.Method()' comparison case.
    @carlossanlop
    carlossanlop committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    e04c8f9 View commit details
    Browse the repository at this point in the history

  3. msbuild /t:pack

    @carlossanlop
    carlossanlop committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c373caf View commit details
    Browse the repository at this point in the history

  4. Address suggestion

    @carlossanlop
    carlossanlop committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    adfdb0d View commit details
    Browse the repository at this point in the history