[BLOCKED] update System.CommandLine #7559
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamsitnik
commented
Feb 3, 2025
|
|
||
| // Hook so we can cancel and exit when ctrl+c is pressed. | ||
| var cancellationTokenSource = new CancellationTokenSource(); | ||
| Console.CancelKeyPress += (sender, e) => |
There was a problem hiding this comment.
This is now being performed out of the box by System.CommandLine. All you need it to pass the cancellation token in SetAction to given async method
adamsitnik
commented
Feb 3, 2025
| var rootCommand = DiffCommand.CreateCommandLineOptions(); | ||
| rootCommand.Handler = CommandHandler.Create(new DiffCommand.Handler(RunAsync)); | ||
|
|
||
| // Parse the incoming args so we can give warnings when deprecated options are used. |
There was a problem hiding this comment.
I was not able to find any other usage of Program.RunAsync so I've assumed that it's most likely some leftover and removed it.
FWIW if there will be any parsing errors detected, the Parse(args).InvokeAsync() call is going to get them printed to output and also return error code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7559 +/- ##
=======================================
Coverage 96.54% 96.54%
=======================================
Files 1454 1454
Lines 352505 352505
Branches 11478 11478
=======================================
+ Hits 340329 340331 +2
+ Misses 9262 9260 -2
Partials 2914 2914 |
adamsitnik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: this PR is blocked until NuGet/NuGet.Client#6236 gets merged (ETA is April).
This PR consists of: