Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependency on MSBuild.Sdk.Extras #247

Closed
tmat opened this issue Feb 7, 2019 · 2 comments · Fixed by #686
Closed

Remove dependency on MSBuild.Sdk.Extras #247

tmat opened this issue Feb 7, 2019 · 2 comments · Fixed by #686
Assignees
@sharwell
Labels
fixed

Comments

@tmat
Copy link
Member

tmat commented Feb 7, 2019

What workaround is needed?
@tmat
Copy link
Member Author

tmat commented Feb 7, 2019

@jmarolf

@jmarolf
Copy link
Contributor

jmarolf commented Feb 7, 2019

This sample needs it: https://github.com/dotnet/roslyn-sdk/blob/master/samples/CSharp/SolutionExplorer/SolutionExplorer.csproj

We'll need to be able to build a WPF project with arcade

sharwell added a commit to sharwell/roslyn-sdk that referenced this issue Dec 23, 2020
@sharwell
Migrate from MSBuild.Sdk.Extras to Microsoft.NET.Sdk.WindowsDesktop
873790b 
Closes dotnet#247
@sharwell sharwell self-assigned this Dec 23, 2020
@sharwell sharwell mentioned this issue Dec 23, 2020
Merged
@sharwell sharwell added the fixed label Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharwell sharwell

Labels
fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate from MSBuild.Sdk.Extras to Microsoft.NET.Sdk.WindowsDesktop sharwell/roslyn-sdk
3 participants
@tmat @sharwell @jmarolf