Update ProgrammaticSuppressionInfoWrapper for Roslyn 4.10 #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ToddGrun
reviewed
Aug 14, 2024
| get | ||
| { | ||
| var suppressions = s_suppressions(_instance); | ||
| if (suppressions is ImmutableHashSet<(string id, LocalizableString justification)> set) |
There was a problem hiding this comment.
Just so I'm clear, there was an even earlier change that changed the signature that also would have broke this, right?
dotnet/roslyn@5287f2f#diff-3dfff6578b6a50be75e51e45981adc7e43b19175986a528500cb0ba3d00e8553
There was a problem hiding this comment.
That commit is the change which caused the break.
ToddGrun
reviewed
Aug 14, 2024
| } | ||
|
|
||
| // https://github.com/dotnet/roslyn-sdk/issues/1175 | ||
| throw new NotImplementedException("The test framework does not yet support suppressions format from Roslyn 4.10+"); |
There was a problem hiding this comment.
It will be closed. If in the future this property is needed for some purpose, it will need to be implemented again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1175