Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exception handler in DiagnosticResult.Message #395

Merged
merged 2 commits into from
Oct 10, 2019
Merged

Add exception handler in DiagnosticResult.Message #395

merged 2 commits into from
Oct 10, 2019

Conversation

nxtn
Copy link
Contributor

@nxtn nxtn commented Sep 29, 2019

To be consistent with DiagnosticResult.ToString, Diagnostic.GetMessage and LocalizableResourceString.GetText when format arguments are not provided.

@nxtn nxtn requested a review from a team as a code owner September 29, 2019 14:21
@nxtn nxtn requested a review from sharwell September 30, 2019 07:19
@sharwell sharwell merged commit 61536ae into dotnet:master Oct 10, 2019
@nxtn nxtn deleted the message branch October 10, 2019 22:58
@nxtn
Copy link
Contributor Author

nxtn commented Oct 11, 2019

@sharwell When will some new packages be published?

@sharwell
Copy link
Member

@NextTurn the new packages are automatically published to myget after merging 👍

@nxtn
Copy link
Contributor Author

nxtn commented Oct 11, 2019

Ah, I see them. But the newer versions 1.0.0-beta1.* are less than the older versions 1.0.0-beta1-*, so the 1.0.0-beta1-63812-02 package published in Feb 2019 is considered as the latest one 😰. You may need to update the version format.

@sharwell
Copy link
Member

Totally agree /cc @JoeRobich

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants