Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically include all compiler diagnostics with IDs that match a provided code fix #421

Merged
merged 15 commits into from
Jan 17, 2020
Merged

Automatically include all compiler diagnostics with IDs that match a provided code fix #421

merged 15 commits into from
Jan 17, 2020

Conversation

taori
Copy link
Contributor

@taori taori commented Jan 16, 2020

this PR fixes #419

@taori taori requested a review from a team as a code owner January 16, 2020 21:19
@taori
Copy link
Contributor Author

taori commented Jan 16, 2020

If you prefer a compositional approach, feel free to let me know. I tried to keep the API changes small.

@taori
Copy link
Contributor Author

taori commented Jan 16, 2020

@sharwell code is update as requested - one question though: How are reviews usually handled? Should i resolve them after updating the code as per review, or is that something which is usually done by the person opening a review?

@taori taori mentioned this pull request Jan 16, 2020
Closed
@sharwell
Copy link
Member

Should i resolve them after updating the code as per review, or is that something which is usually done by the person opening a review?

It tends to vary. You can go with whatever approach you're comfortable with.

taori and others added 4 commits January 17, 2020 00:28
@taori @sharwell
Update src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Anal…
c0e721c 
…yzer.Testing/AnalyzerTest`1.cs

Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
@taori @sharwell
Update src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Anal…
80f220b 
…yzer.Testing/AnalyzerTest`1.cs

Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
@taori @sharwell
Update src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Anal…
c9d5c3c 
…yzer.Testing/AnalyzerTest`1.cs

Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
@taori @sharwell
Update src/Microsoft.CodeAnalysis.Testing/Microsoft.CodeAnalysis.Anal…
de64475 
…yzer.Testing/AnalyzerTest`1.cs

Co-Authored-By: Sam Harwell <sam@tunnelvisionlabs.com>
@taori
Copy link
Contributor Author

taori commented Jan 17, 2020 •
edited
Loading

@sharwell if this were to be merged, now that the PR is ready again, would it end up straight in the beta channel?

@sharwell
Copy link
Member

@taori Yes, it will automatically go to MyGet after it's merged.

@sharwell
Copy link
Member

I'm just waiting on the refactoring so IsCompilerDiagnostic is called before IsCompilerDiagnosticIncluded is called.

@sharwell sharwell requested a review from jmarolf January 17, 2020 17:10
jmarolf
jmarolf approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@jmarolf jmarolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sharwell sharwell merged commit 869a894 into dotnet:master Jan 17, 2020
@sharwell
Copy link
Member

Thanks @taori !!

@taori
Copy link
Contributor Author

taori commented Jan 17, 2020 •
edited
Loading

@sharwell Thanks for your guidance and feedback :) + Enjoy your weekend

@taori taori deleted the fix-for-419 branch January 17, 2020 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sharwell sharwell sharwell approved these changes

@jmarolf jmarolf jmarolf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatically include all compiler diagnostics with IDs that match a provided code fix
3 participants
@taori @sharwell @jmarolf