Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Update dependencies from dotnet/arcade #630

Merged

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Sep 19, 2020

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 66bf0ed9-59cb-4fe0-6937-08d6a0d7585c
  • Build: 20200928.3
  • Date Produced: 9/28/2020 10:44 PM
  • Commit: c8a7611e15656f45b039d46ec4e09f9f2a7edf99
  • Branch: refs/heads/master

dotnet-maestro bot and others added 6 commits September 19, 2020 12:07
…917.6

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.20465.7 -> To Version 5.0.0-beta.20467.6
…921.1

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.20465.7 -> To Version 5.0.0-beta.20471.1
…922.36

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.20465.7 -> To Version 5.0.0-beta.20472.36
…924.4

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.20465.7 -> To Version 5.0.0-beta.20474.4
…928.3

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.20465.7 -> To Version 5.0.0-beta.20478.3
@jmarolf
Copy link
Contributor

jmarolf commented Oct 5, 2020

@sharwell would appreciate your opinion here. What do we want to do?

  1. Support .NET Core 1.0 and .NET Core 2.0 in November even though they are out of support?
  2. Have a policy to drop support for unsupported .NET frameworks

@sharwell
Copy link
Member

sharwell commented Oct 5, 2020

@jmarolf There is no need/value in dropping support for .NET Core 1.0 or .NET Core 2.0. These targets are used for testing analyzers that will continue to support Visual Studio 2015 environments for at least the next 5 years.

@jmarolf
Copy link
Contributor

jmarolf commented Oct 5, 2020

figured you'd say that :) but I wanted to check. I'll add

<CheckEolTargetFramework>false</CheckEolTargetFramework>

to our props

@dotnet-maestro dotnet-maestro bot requested review from a team as code owners October 5, 2020 15:25
@dotnet-maestro dotnet-maestro bot merged commit 4b3da31 into master Oct 5, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-master-bf3f3bcf-1a43-4e5a-b0d3-8490f8a2bdb9 branch October 5, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants