Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully support additional projects #680

Merged
merged 10 commits into from
Dec 23, 2020
Merged

Conversation

sharwell
Copy link
Member

Fixes #464

@sharwell
Copy link
Member Author

I checked dotnet/roslyn-analyzers for compatibility and found the following:

  • The (significant) API breaking changes in this pull request did not result in any compilation errors for the repository.
  • Due to the limitations of the previous AdditionalProjects property, dotnet/roslyn-analyzers did not use it and instead added additional projects through the SolutionTransforms property. All current cases where SolutionTransforms is used to add additional projects worked through the new AdditionalProjects property without needing to continue using the SolutionTransforms property.

@sharwell
Copy link
Member Author

I checked out DotNetAnalyzers/StyleCopAnalyzers and found similar results to above. The tests did not include any multi-assembly tests, but did set OutputKind and DocumentationMode through solution transforms. I converted the tests to the new properties of ProjectState and they passed as expected.

@sharwell sharwell marked this pull request as ready for review December 23, 2020 07:50
@sharwell sharwell requested a review from a team as a code owner December 23, 2020 07:50
@sharwell sharwell merged commit 2bf7c28 into dotnet:master Dec 23, 2020
@sharwell sharwell deleted the more-projects branch December 23, 2020 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fully support additional projects
2 participants