Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose workspaces at the end of RunAsync #809

Merged
merged 1 commit into from
May 3, 2021
Merged

Dispose workspaces at the end of RunAsync #809

merged 1 commit into from
May 3, 2021

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented May 3, 2021

Fixes #805

@sharwell sharwell requested a review from a team as a code owner May 3, 2021 19:15
@sharwell sharwell force-pushed the dispose-workspace branch from 7c5b208 to fefb059 Compare May 3, 2021 19:40
@sharwell sharwell merged commit e8447d9 into dotnet:main May 3, 2021
@sharwell sharwell deleted the dispose-workspace branch May 3, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmarolf jmarolf jmarolf approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Overriding AnalzyerTest.CreateWorkspace can lead to a non-disposed workspace being created.
3 participants
@sharwell @CyrusNajmabadi @jmarolf