Address feedback

dotnet · Oct 19, 2021 · 004bf65 · CyrusNajmabadi · Oct 19, 2021 · 004bf65
1 parent a55501f
commit 004bf65
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 5 deletions.
diff --git a/src/Compilers/CSharp/Portable/Syntax/SyntaxNormalizer.cs b/src/Compilers/CSharp/Portable/Syntax/SyntaxNormalizer.cs
@@ -522,7 +522,7 @@ private static bool NeedsSeparatorForPositionalPattern(SyntaxToken token, Syntax
 
         private static bool NeedsSeparatorForListPattern(SyntaxToken token, SyntaxToken next)
         {
-            ListPatternSyntax? listPattern;
+            ListPatternSyntax listPattern;
             if (token.Parent.IsKind(SyntaxKind.ListPattern))
             {
                 listPattern = (ListPatternSyntax)token.Parent;
@@ -537,15 +537,13 @@ private static bool NeedsSeparatorForListPattern(SyntaxToken token, SyntaxToken
             }
 
             // is$$[1, 2]
-            var nextIsOpenBracket = next.IsKind(SyntaxKind.OpenBracketToken);
-            if (nextIsOpenBracket)
+            if (next.IsKind(SyntaxKind.OpenBracketToken))
             {
                 return true;
             }
 
             // is [1, 2]$$list
-            var tokenIsOpenBracket = token.IsKind(SyntaxKind.OpenBracketToken);
-            if (tokenIsOpenBracket)
+            if (token.IsKind(SyntaxKind.OpenBracketToken))
             {
                 return listPattern.Designation is not null;
             }

diff --git a/src/EditorFeatures/CSharpTest/AutomaticCompletion/AutomaticBracketCompletionTests.cs b/src/EditorFeatures/CSharpTest/AutomaticCompletion/AutomaticBracketCompletionTests.cs
@@ -250,6 +250,33 @@ public void Array_Nested()
             CheckStart(session.Session);
         }
 
+        [WpfFact, Trait(Traits.Feature, Traits.Features.AutomaticCompletion)]
+        public void ListPattern()
+        {
+            var code = @"
+class C
+{
+    void M(object o)
+    {
+        _ = o is $$
+    }
+}
+";
+            var expected = @"
+class C
+{
+    void M(object o)
+    {
+        _ = o is [
+]
+    }
+}
+";
+            using var session = CreateSession(code);
+            CheckStart(session.Session);
+            CheckReturn(session.Session, 0, expected);
+        }
+
         internal static Holder CreateSession(string code)
         {
             return CreateSession(