Skip to content

Commit

Permalink
Merge pull request #58100 from dotnet/dev/jorobich/skip-test
Browse files Browse the repository at this point in the history
Skip flaky CommandLine.ArgumentParsing test

See #58077 for more details
  • Loading branch information
JoeRobich authored Dec 3, 2021
1 parent 6493157 commit 0b2c30d
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/Compilers/CSharp/Test/CommandLine/CommandLineTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1410,7 +1410,9 @@ public void ModuleManifest()
Assert.Equal("blah", args.Win32Manifest);
}

[Fact]
// The following test is failing in the Linux Debug test leg of CI.
// This issus is being tracked by https://github.com/dotnet/roslyn/issues/58077
[ConditionalFact(typeof(WindowsOrMacOSOnly))]
public void ArgumentParsing()
{
var sdkDirectory = SdkDirectory;
Expand Down
6 changes: 6 additions & 0 deletions src/Compilers/Test/Core/Assert/ConditionalFactAttribute.cs
Original file line number Diff line number Diff line change
Expand Up @@ -300,6 +300,12 @@ public class UnixLikeOnly : ExecutionCondition
public override string SkipReason => "Test not supported on Windows";
}

public class WindowsOrMacOSOnly : ExecutionCondition
{
public override bool ShouldSkip => PathUtilities.IsUnixLikePlatform && !ExecutionConditionUtil.IsMacOS;
public override string SkipReason => "Test not supported on Linux";
}

public class WindowsOrLinuxOnly : ExecutionCondition
{
public override bool ShouldSkip => ExecutionConditionUtil.IsMacOS;
Expand Down

0 comments on commit 0b2c30d

Please sign in to comment.